Bug report: NRE on Bind when SystemType is not set up
Posted: Tue Aug 11, 2009 10:02 am
Hi there!
Now i have sources and can point exact lines in files where there are errors
Steps to reproduce:
and SystemType is not set up.
in bindResp there will be CommandStatus.SMPPCLIENT_UNKNOWNERROR
and there will be OnError.
With sources it is obvious:
in class pduBind when you try to set SystemType to null it fails with NRE, since you try to check it's length.
i suggest to set SystemType of SmppClient to string.Empty not null, or throw more explaining exception.
Now i have sources and can point exact lines in files where there are errors
Steps to reproduce:
Code: Select all
smppClient.Connect(config.HostName, config.Port);
pduBindResp bindResp = smppClient.Bind(config.SystemId, config.Password);
in bindResp there will be CommandStatus.SMPPCLIENT_UNKNOWNERROR
and there will be OnError.
With sources it is obvious:
in class pduBind when you try to set SystemType to null it fails with NRE, since you try to check it's length.
i suggest to set SystemType of SmppClient to string.Empty not null, or throw more explaining exception.